Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-125 Disable comments #133

Merged
merged 2 commits into from
Apr 5, 2016
Merged

PLAT-125 Disable comments #133

merged 2 commits into from
Apr 5, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Apr 5, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-125

Changes proposed in this pull request

  • disable comments

@pvhee
Copy link
Contributor

pvhee commented Apr 5, 2016

@Saphyel we're sure this doesn't touch any other yml files right? i.e. doing phing config:export is entirely clean after removing comment?

@bimsonz
Copy link
Contributor

bimsonz commented Apr 5, 2016

After testing locally, running phing config:export this looks good to me...

@Saphyel
Copy link
Contributor Author

Saphyel commented Apr 5, 2016

@pvhee I tried on my local and nothing breaks, no dependencies issue, and using config:export I have a few changes but isn't related with this PR. Also Travis is happy with this PR

@pvhee pvhee merged commit 20c7b54 into develop Apr 5, 2016
@pvhee pvhee deleted the feature/PLAT-125 branch April 5, 2016 09:53
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants