PLAT-60 search display view modes

[AndyEPhipps]

https://jira.comicrelief.com/browse/PLAT-60

[bimsonz]

@AndyEPhipps so them problem here is that because you've changed the view modes for the search, the test for search no longer pass...

We need to update the test as part of this branch, @wagg-matt are you able to assist andy with this? need to look at what best to test so this doesnt have to change everytime the viewmode is altered slightly? imo this should be a functional test, maybe test to see if markup is there or something ? /FYI @pvhee

[gusliedke]

Yeah, maybe do a bit more generic test for elements / functionalities that aren't finished yet.

[wagg-matt]

@bimsonz of course. @AndyEPhipps give me a shout when you want to go through it and i'll head over

[gusliedke]

@AndyEPhipps Let's try to achieve this markup.

We can make one template for all search results and one file for its style.

<div class="search-result">
    <h2 class="search-result__title"></h2>
    <div class="search-result__image">
        <img src="#" alt="image title">
    </div>
    <a class="search-result__link" href="#">Read more</a>
</div>

Sass file can have same name as element. ie. _search-result.scss

[pvhee]

@AndyEPhipps @wagg-matt @bimsonz I fixed the behat tests (let's wait for travis to confirm), see commit 051c8d5 - don't think we have to be too worried about front-end changes for the future, the point is that when you look for "malaria" you should return two pages, and when looking for "lindsey" you also have two results (both of them not articles but landing pages). Content is part of the build, so that's what we should be asserting, and at the same time this checks that the entire search stack is functioning correctly.

[pvhee]

@AndyEPhipps is this ready to go in now?

[peter-brady]

@AndyEPhipps @bimsonz @pvhee

Thinking dependency hell here, to be honest. Here's why.

We have these view modes defines in the search module. They view modes are for the Partners node type, and a few others. Thing is, does that mean this module depends on the Partners content type being available? Because it's likely that some sites won't have a Partner content type enabled Eg. comicrelief.com for example.

Thinking we should do a little more testing in the area of dependencies before we start getting too many modules with all these dependencies into the codebase.

What do you think?

[gusliedke]

@AndyEPhipps I don't think we need to commit add this file.

[gusliedke]

@AndyEPhipps I think there are some files that need to be deleted. I left a comment on them.

[pvhee]

@gusliedke @AndyEPhipps just a FYI that we'll need to redo some of the work to make sure the search view modes are updated to the new look & feel - currently this looks all a bit broken (as expected)

Related to our main search PR: #531

@gusliedke will probably pop in a new ticket for the front-end work required

[gusliedke]

We have this one for search front end work https://jira.comicrelief.com/browse/PLAT-485