Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-150 Exporting page #158

Merged
merged 5 commits into from
Apr 12, 2016
Merged

Conversation

pvhee
Copy link
Contributor

@pvhee pvhee commented Apr 12, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-150

Changes proposes in this PR

  • Refactored page export snippets inside new cr_page module
  • @gusliedke Add a sample page node in json format

@pvhee
Copy link
Contributor Author

pvhee commented Apr 12, 2016

@gusliedke confirming the error and figured out why this happens: when enabling modules (cr_default_content, which holds this exported page), the config/install snippets from the profile are not yet installed, so enabling cr_default_content fails. This is very annoying behavior and I see 2 ways of fixing this:

  • enable cr_default_content after installing the site (as part of the phing build, and separately on travis)
  • factor out all the exported page content type .yml files and put in cr_page rather than as part of the profile.

@bimsonz what do you think?

@pvhee
Copy link
Contributor Author

pvhee commented Apr 12, 2016

@gusliedke this seems to work - could you put in a proper content export instead? you can edit the same page node I put as part of be41cf9

@AndyEPhipps
Copy link
Contributor

Some boring footer-style pages added

@pvhee
Copy link
Contributor Author

pvhee commented Apr 12, 2016

@AndyEPhipps sweet, merging in

@pvhee pvhee merged commit 37097fe into develop Apr 12, 2016
@pvhee pvhee deleted the feature/PLAT-150_page_default_content branch April 12, 2016 15:46
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants