Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-152 Rename fields #170

Merged
merged 8 commits into from
Apr 19, 2016
Merged

PLAT-152 Rename fields #170

merged 8 commits into from
Apr 19, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Apr 18, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-152

Changes proposed in this pull request

  • Rename Articles
  • Rename Landing
  • Rename Partners

Notes to consider:

  1. Ignore Youtube field for article - there's a separate ticket raised to remove field
  2. READ.md for cr_partner is already upto date so no change required

@vireshpatel
Copy link
Contributor

@Saphyel name changes looks all good

@pvhee @peter-brady @bimsonz
Guys, Landing page has paragraphs field and panelizer field - need guidance/discussion how to progress as these fields are used elsewhere, e.g. content wall.

Also @Saphyel has highlighted if we're to go down the route of not having site wide fields, then title and body falls outside to the rule - is this ok?

@bimsonz
Copy link
Contributor

bimsonz commented Apr 18, 2016

Ah my bad, i didnt read that this was for all content types...

I think we should have content type specific fields for panelizer and paragraphs to be honest, its the same concept/ type of issues that we'd run into imo

@Saphyel
Copy link
Contributor Author

Saphyel commented Apr 18, 2016

well my 2c, change that fields can be done later in another PR when we know what we want to do with them.

@bimsonz
Copy link
Contributor

bimsonz commented Apr 18, 2016

I'd say we do know what we want to do with them, we'll probably add another paragraph field to landing pages as well as the existing one

@pvhee
Copy link
Contributor

pvhee commented Apr 19, 2016

Looks fine for me, merging this in, @Saphyel can you add in a ticket to deal with the paragraph field? I am not sure you can have a panelizer field per content type though, \cc @bimsonz

@pvhee pvhee merged commit 389cc8d into develop Apr 19, 2016
@pvhee pvhee deleted the feature/PLAT-152_rename branch April 19, 2016 09:45
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants