PLAT-176 update core #178
PLAT-176 update core #178
Conversation
|
@Saphyel Looks good to me, let me try it locally and ill update here! |
| @@ -89,6 +89,7 @@ | |||
| command="${drush.bin} make -y ${app.profile.dir}drupal-org.make.yml --no-gitprojectinfo --no-gitinfofile --no-core --contrib-destination=${app.profile.dir}"/> | |||
| </target> | |||
| <target name="install" description="Install CR with standard configuration."> | |||
| <exec logoutput="true" passthru="true" command="composer install --prefer-dist"/> | |||
There was a problem hiding this comment.
Im not sure we want this inside the install... i think this is best suited within <target name="build:prepare" depends="grunt:dependencies, test:install:composer" description="Build (or rebuild) the project.">
Maybe create a separate job for composer install and have this build:prepare depend on that
There was a problem hiding this comment.
I don't agree to use there, because you don't usually use that command, and if we update core and someone is not aware or on holidays he probably will spend ages debugging why is not working, and execute composer doesn't take more than 2secs...
|
@Saphyel Left a line note for you to action please dude, will merge after that is done. |
|
@Saphyel thanks for making the composer change and adding that patch... is this ready for merge ? |
Fixes https://jira.comicrelief.com/browse/PLAT-176
Changes proposed in this pull request