Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-181 Fix search #185

Merged
merged 6 commits into from
Apr 27, 2016
Merged

PLAT-181 Fix search #185

merged 6 commits into from
Apr 27, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Apr 21, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-181

Changes proposed in this pull request

  • While indexing items on search index CR Content, 6 item(s) did not have a view mode configured for the Rendered item processor.
  • An overlong word (more than 50 characters) was encountered while indexing: 90f8a1679d8614fda8c869fcf3b2897562d83acb7f55036a23dd182ff2038537.Database search servers currently cannot index

@Saphyel Saphyel changed the title PLAT-181 #in-progress Update config PLAT-181 Fix search Apr 21, 2016
@Saphyel
Copy link
Contributor Author

Saphyel commented Apr 21, 2016

@pvhee @bimsonz the second error comes from a landing page content

@@ -19,7 +19,6 @@ config_devel:
- core.entity_form_display.node.partner.default
- core.entity_view_display.node.partner.default
- core.entity_view_display.node.partner.teaser
- core.entity_view_display.node.partner.search_index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, I also removed this in another PR :)

@pvhee
Copy link
Contributor

pvhee commented Apr 21, 2016

@Saphyel can you refactor that content to not have these longs words pls? It isn't very relevant since we won't have a db search server, but just for the tests to pass

@Saphyel
Copy link
Contributor Author

Saphyel commented Apr 25, 2016

@pvhee the problem is here:

],
    "panelizer": [
        {
            "view_mode": "full",
            "default": null,
            "panels_display": {
                "blocks": {
                    "b212ceb5-87af-4155-ad09-9f468d9eb926": {
                        "id": "entity_view:node",
                        "label": "Entity view (Content)",
                        "provider": "ctools",
                        "label_display": "0",
                        "view_mode": "landing_page_header",
                        "context_mapping": {
                            "entity": "@panelizer.entity_context:entity"
                        },
                        "region": "first",
                        "uuid": "b212ceb5-87af-4155-ad09-9f468d9eb926",
                        "weight": 1
                    },
                    "0df3b443-cd24-4f55-be00-d27e656349c6": {
                        "id": "entity_field:node:field_paragraphs",
                        "label": "Paragraphs",
                        "provider": "ctools_block",
                        "label_display": "0",
                        "formatter": {
                            "label": "hidden",
                            "type": "entity_reference_revisions_entity_view",
                            "settings": {
                                "view_mode": "default"
                            },
                            "third_party_settings": [],
                            "weight": 0
                        },
                        "context_mapping": {
                            "entity": "@panelizer.entity_context:entity"
                        },
                        "region": "second",
                        "uuid": "0df3b443-cd24-4f55-be00-d27e656349c6",
                        "weight": 1
                    },
                    "b8357052-8626-4967-8600-cb92a4ad94a9": {
                        "id": "views_block:related_news-block_1",
                        "label": "",
                        "provider": "views",
                        "label_display": "visible",
                        "views_label": "",
                        "items_per_page": "10",
                        "context_mapping": [],
                        "region": "first",
                        "uuid": "b8357052-8626-4967-8600-cb92a4ad94a9",
                        "weight": 2
                    },
                    "497ef3fb-b56b-43ce-9003-3ad95d8ee1d3": {
                        "id": "views_block:what_s_going_on-block_1",
                        "label": "",
                        "provider": "views",
                        "label_display": 0,
                        "views_label": "",
                        "items_per_page": "none",
                        "context_mapping": [],
                        "region": "third",
                        "uuid": "497ef3fb-b56b-43ce-9003-3ad95d8ee1d3",
                        "weight": 1
                    }
                },
                "id": "panels_variant",
                "uuid": "07727bfe-7661-4185-a418-24b2dd3f797d",
                "label": "",
                "weight": 0,
                "layout": "fiveregions",
                "layout_settings": [],
                "page_title": "[node:title]",
                "storage_type": "panelizer_field",
                "storage_id": "node:17:full:17",
                "builder": "ipe"
            },
            "lang": "en"
        }

I guess you don't want to remove the pnelizer from the "what's going on" landing page

@pvhee
Copy link
Contributor

pvhee commented Apr 26, 2016

@Saphyel no, we'd have to keep this - can we reduce error check to not break on warnigns then, but maybe just print them out?

@Saphyel
Copy link
Contributor Author

Saphyel commented Apr 26, 2016

@pvhee I'll do, then this branch is ready to merge/Code review? nothing left to do

@pvhee
Copy link
Contributor

pvhee commented Apr 26, 2016

@Saphyel Travis is breaking here, can you fix pls?

@wagg-matt wagg-matt merged commit 4b06355 into develop Apr 27, 2016
@wagg-matt wagg-matt deleted the feature/PLAT-181_update_search branch April 27, 2016 15:28
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants