This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -19,7 +19,6 @@ config_devel: | |||
- core.entity_form_display.node.partner.default | |||
- core.entity_view_display.node.partner.default | |||
- core.entity_view_display.node.partner.teaser | |||
- core.entity_view_display.node.partner.search_index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call, I also removed this in another PR :)
@Saphyel can you refactor that content to not have these longs words pls? It isn't very relevant since we won't have a db search server, but just for the tests to pass |
@pvhee the problem is here:
I guess you don't want to remove the pnelizer from the "what's going on" landing page |
@Saphyel no, we'd have to keep this - can we reduce error check to not break on warnigns then, but maybe just print them out? |
@pvhee I'll do, then this branch is ready to merge/Code review? nothing left to do |
@Saphyel Travis is breaking here, can you fix pls? |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.comicrelief.com/browse/PLAT-181
Changes proposed in this pull request