Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-192 footer menu #203

Merged
merged 11 commits into from
Apr 27, 2016
Merged

PLAT-192 footer menu #203

merged 11 commits into from
Apr 27, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Apr 27, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-192

Changes proposed in this pull request

  • Add pathauto
  • Add menu links

@bimsonz bimsonz assigned bimsonz and unassigned gusliedke Apr 27, 2016
@bimsonz
Copy link
Contributor

bimsonz commented Apr 27, 2016

Building locally

@bimsonz
Copy link
Contributor

bimsonz commented Apr 27, 2016

@Saphyel only the partner page is using pathauto, is this supposed to be like this ? the first two links have node/* urls

@Saphyel
Copy link
Contributor Author

Saphyel commented Apr 27, 2016

@bimsonz mh, nop I added the pathauto for fix that...

@bimsonz
Copy link
Contributor

bimsonz commented Apr 27, 2016

@Saphyel When i build locally it wasnt the case, can you please take a look ? :)

@Saphyel
Copy link
Contributor Author

Saphyel commented Apr 27, 2016

@bimsonz it's weird... when I do phing instal, comes without it, so I go to admin/config/search/path/update_bulk I create the aliases and when I update the nodes they keep node/1 ...

@bimsonz
Copy link
Contributor

bimsonz commented Apr 27, 2016

@Saphyel I think this might be because you are creating a menu item rather than creating it from a page... im going to merge this in and fix in #198

@bimsonz bimsonz assigned bimsonz and unassigned Saphyel Apr 27, 2016
@bimsonz bimsonz merged commit 8380acf into develop Apr 27, 2016
@bimsonz bimsonz deleted the feature/PLAT-192_footer_menu branch April 27, 2016 16:42
@Saphyel Saphyel mentioned this pull request Apr 28, 2016
5 tasks
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants