Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

Feature/plat 198 promo header #215

Merged
merged 38 commits into from
May 11, 2016
Merged

Conversation

gusliedke
Copy link
Contributor

@gusliedke gusliedke commented May 3, 2016

https://jira.comicrelief.com/browse/PLAT-198

Changes proposed in this pull request

  • rename landing page header to Promo Header
  • add dark copy light bg

@pvhee
Copy link
Contributor

pvhee commented May 4, 2016

Just documenting this to look later into it.

We have a recursiveness issue exporting the fundraise landing page, using drush dcer:

peterv@CRadmins-MacBook-Pro-2~/Sites/comicrelief/campaign$ drush8 dcer node 12 --folder=profiles/cr/modules/custom/cr_default_content/content/ 
PHP Fatal error:  Nesting level too deep - recursive dependency? in /Users/peterv/Sites/comicrelief/campaign/profiles/cr/modules/contrib/default_content/src/DefaultContentManager.php on line 353
PHP Stack trace:
PHP   1. {main}() /usr/local/lib/drush/drush.php:0
PHP   2. drush_main() /usr/local/lib/drush/drush.php:12
PHP   3. Drush\Boot\BaseBoot->bootstrap_and_dispatch() /usr/local/lib/drush/includes/preflight.inc:64
PHP   4. drush_dispatch() /usr/local/lib/drush/lib/Drush/Boot/BaseBoot.php:65
PHP   5. call_user_func_array:{/usr/local/lib/drush/includes/command.inc:183}() /usr/local/lib/drush/includes/command.inc:183
PHP   6. drush_command() /usr/local/lib/drush/includes/command.inc:183
PHP   7. _drush_invoke_hooks() /usr/local/lib/drush/includes/command.inc:215
PHP   8. call_user_func_array:{/usr/local/lib/drush/includes/command.inc:364}() /usr/local/lib/drush/includes/command.inc:364
PHP   9. drush_default_content_export_references() /usr/local/lib/drush/includes/command.inc:364
PHP  10. Drupal\default_content\DefaultContentManager->exportContentWithReferences() /Users/peterv/Sites/comicrelief/campaign/profiles/cr/modules/contrib/default_content/drush/default_content.drush.inc:90
PHP  11. Drupal\default_content\DefaultContentManager->getEntityReferencesRecursive() /Users/peterv/Sites/comicrelief/campaign/profiles/cr/modules/contrib/default_content/src/DefaultContentManager.php:274
PHP  12. array_unique() /Users/peterv/Sites/comicrelief/campaign/profiles/cr/modules/contrib/default_content/src/DefaultContentManager.php:353

…f/campaign into feature/PLAT-198_promo_header
@bimsonz
Copy link
Contributor

bimsonz commented May 6, 2016

Ready for merge @gusliedke ?

@gusliedke
Copy link
Contributor Author

in good status to be merged

@bimsonz bimsonz assigned bimsonz and unassigned gusliedke May 10, 2016
@bimsonz
Copy link
Contributor

bimsonz commented May 10, 2016

@gusliedke Will merge once travis goes green

@bimsonz
Copy link
Contributor

bimsonz commented May 10, 2016

@gusliedke Got a issue with the file

 [error]  exception 'Exception' with message 'Default content with href http://default/file/33?_format=hal_json exists twice: profiles/cr/modules/custom/cr_default_content/content/file/15d56c00-cbcf-428c-9f81-773356232bde.json profiles/cr/modules/custom/cr_default_content/content/file/42607d12-f8ce-4a93-bcc0-0dd0c1311ada.json' in /home/travis/build/comicrelief/campaign/profiles/cr/modules/contrib/default_content/src/DefaultContentManager.php:191

@gusliedke
Copy link
Contributor Author

@bimsonz json file fixed

@bimsonz bimsonz merged commit 8ba123d into develop May 11, 2016
@bimsonz bimsonz deleted the feature/PLAT-198_promo_header branch May 11, 2016 09:45
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants