Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-20 Refactor #23

Merged
merged 8 commits into from
Feb 18, 2016
Merged

PLAT-20 Refactor #23

merged 8 commits into from
Feb 18, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Feb 15, 2016

http://jira.comicrelief.com/browse/PLAT-20

  • add enough sample content to enable pagination, at least 2 pages
  • generic site fields should be part of the CR profile, not of cr_article
  • rethink field_type_news

@pvhee
Copy link
Contributor

pvhee commented Feb 16, 2016

@Saphyel can you also make sure we have pagination enabled in that page? so we need more than the 5 news we currently have

@pvhee
Copy link
Contributor

pvhee commented Feb 16, 2016

Also, for oc_default_content we need to add the UUID to the .info.yml file, like it's done in agov_default_content.info.yml. Could you add that?

@Saphyel
Copy link
Contributor Author

Saphyel commented Feb 16, 2016

Pagination is working with 6 and there is 7 news.

is already working without it... Is not a big issue add them... But could you say why?

@pvhee
Copy link
Contributor

pvhee commented Feb 17, 2016

@Saphyel so you can update the content easily using the default_content update drush command (works similarly to the config_devel commands)

pvhee added a commit that referenced this pull request Feb 18, 2016
@pvhee pvhee merged commit a1d0661 into develop Feb 18, 2016
@pvhee pvhee deleted the feature/PLAT-20_refactor branch February 18, 2016 14:14
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants