This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
PLAT-226 move gems #241
Merged
PLAT-226 move gems #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1 +0,0 @@ | |||
| 2.1.5 | |||
There was a problem hiding this comment.
because it now lives within the root and is gitignored, any specific reason we need it in the repo ?
There was a problem hiding this comment.
It's good to have it in the repo as rvm/rbenv respect it and automatically switches users to that version. I.e. if people have multiple projects with different versions they don't have to manually switch
There was a problem hiding this comment.
Sweet, its reinstated
| @@ -43,7 +43,7 @@ module.exports = function (grunt) { | |||
|
|
|||
| shell: { | |||
| styleguide: { | |||
| command: 'node_modules/kss/bin/kss-node --source profiles/cr/themes/custom/campaign_base/sass/ --css ../css/styles.css --verbose --title "Comic Relief PatternLab"' | |||
| command: 'node_modules/kss/bin/kss-node --source profiles/cr/themes/custom/campaign_base/sass/ --destination profiles/cr/themes/custom/campaign_base/styleguide --css ../css/styles.css --verbose --title "Comic Relief PatternLab"' | |||
There was a problem hiding this comment.
@gusliedke \FYI added destination param
|
@gusliedke merge away |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.comicrelief.com/browse/PLAT-226