This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
Feature/plat 204 footer update #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/PLAT-204_Footer_update
| {% endif %} | ||
|
|
||
| <div class="footer__copyright"> | ||
| <p>© Comic Relief 2015. Comic Relief, registered charity 326568 (England/Wales); SC039730 (Scotland)</p> |
There was a problem hiding this comment.
Date update. checkout twig filter date http://twig.sensiolabs.org/doc/filters/date.html
is it copyright in html format? ©
There was a problem hiding this comment.
Ah nice! Will put that in and update copyright symbol to HTML code
…o feature/PLAT-204_Footer_update
|
@gusliedke @AndyEPhipps I assume we'll be using SVGs for icons across the site? If this is the case shouldn't we have the sprite just beneath the opening body tag? They won't always work when the sprite out put after it's being called with . Issue is on iOS: https://24ways.org/2014/an-overview-of-svg-sprite-creation-techniques/ search for Safari and you'll find it |
|
@AndyEPhipps we need to move |
…omicrelief/campaign into feature/PLAT-204_Footer_update
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.comicrelief.com/browse/PLAT-204