This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.comicrelief.com/browse/PLAT-235
Changes proposed in this pull request
Reasoning behind this
As reported in https://jira.comicrelief.com/browse/PLAT-235, we have a problem editing a node that contains paragraphs, as it returns an
EntityChangedConstraint
(text reads likeThe content has either been modified by another user, or you have already submitted modifications. As a result, your changes cannot be saved.
).From
EntityChangedConstraintValidator
, this happens when the changed time of the updated entity is lower then the changed time of the entity to be updated, meaning that a user is likely to change an entity that has been changed in the meantime.This makes a lot of sense for nodes, but somehow gets messed up for paragraph entities that should not have an updated date (they belong to the host entity!). This has been reported and supposedly fixed for paragraphs in https://www.drupal.org/node/2715855, but applying this patch leads to a new issue: This entity (paragraph: ) cannot be referenced `, which has been reported in https://www.drupal.org/node/2724243 (set to critical) and for which currently (May 18th) no solution exists.
Hence the reason to apply a core patch to remove this constraint for paragraphs. It should be harmless, and can be removed once the solution is properly fixed in paragraphs.