Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-242 header update v2 #259

Merged
merged 5 commits into from
May 23, 2016
Merged

Conversation

gusliedke
Copy link
Contributor

@bimsonz bimsonz changed the title Feature/plat 242 header update v2 PLAT-242 header update v2 May 20, 2016
@pvhee
Copy link
Contributor

pvhee commented May 20, 2016

@gusliedke did we review also something like https://www.drupal.org/project/svg_embed? Also left a comment in http://jira.comicrelief.com/browse/PLAT-200 but feel free to go ahead with this approach.

@gusliedke
Copy link
Contributor Author

@pvhee I don't think we need a module for that. I'm using a twig filter (| raw) to output code from the plain long text field in my twig template. This works fine.

@Saphyel Saphyel merged commit 719b70c into develop May 23, 2016
@Saphyel Saphyel deleted the feature/PLAT-242_header_update_v2 branch May 23, 2016 09:06
@bimsonz
Copy link
Contributor

bimsonz commented May 23, 2016

@Saphyel did you test this before you merged it? I've got a feeling you didn't. The field storage for field_svg_body_title hasn't been added to the info file. Can you or @gusliedke create a PR on Campaign to fix this please?

@gusliedke
Copy link
Contributor Author

@bimsonz
Copy link
Contributor

bimsonz commented May 23, 2016

the field is @gusliedke but the field.storage.node.field_svg_body_title isn't... the field is in the config directory some how but the reference to it isn't. I noticed this when re importing the config in RND

@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants