Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-32 Add yml #29

Merged
merged 2 commits into from
Feb 18, 2016
Merged

PLAT-32 Add yml #29

merged 2 commits into from
Feb 18, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Feb 18, 2016

http://jira.comicrelief.com/browse/PLAT-32

  • Add *.yml files
  • Update phing

@Saphyel
Copy link
Contributor Author

Saphyel commented Feb 18, 2016

@pvhee could you code review this?

output on my local:

phing make-core
Buildfile: /srv/www/campaign/build.xml
 [property] Loading /srv/www/campaign/build.properties

cr > make:

Make new site in the current directory? (y/n): y
Beginning to build profiles/cr/drupal-org.make.yml.                                                                                                                  [ok]
Project ctools contains 2 modules: ctools_views, ctools.
ctools-8.x-3.0-alpha22 downloaded.                                                                                                                                   [ok]
file_entity-8.x-2.x-dev downloaded.                                                                                                                                  [ok]
pathauto-8.x-1.0-alpha1 downloaded.                                                                                                                                  [ok]
token-8.x-1.0-alpha2 downloaded.                                                                                                                                     [ok]
youtube-8.x-1.0-beta2 downloaded.                                                                                                                                    [ok]
Project layout_plugin contains 3 modules: block_page_layout, layout_plugin_example, layout_plugin.
layout_plugin-8.x-1.0-alpha22 downloaded.                                                                                                                            [ok]
Project page_manager contains 2 modules: page_manager_ui, page_manager.
page_manager-8.x-1.0-alpha23 downloaded.                                                                                                                             [ok]
inline_entity_form-8.x-1.0-alpha3 downloaded.                                                                                                                        [ok]
Project panels contains 2 modules: panels_ipe, panels.
panels-8.x-3.0-beta4 downloaded.                                                                                                                                     [ok]
config_devel-8.x-1.0-rc1 downloaded.                                                                                                                                 [ok]
default_content-8.x-1.0-alpha2 downloaded.                                                                                                                           [ok]
Project admin_toolbar contains 2 modules: admin_toolbar_tools, admin_toolbar.
admin_toolbar-8.x-1.14 downloaded.                                                                                                                                   [ok]

cr > make-core:

Make new site in the current directory? (y/n): y
Beginning to build profiles/cr/drupal-org-core.make.yml.                                                                                                             [ok]
drupal-8.0.3 downloaded.                                                                                                                                             [ok]
drupal patched with 1232572-57.drupal.disable-file-permissions-fix.patch.                                                                                            [ok]
Generated PATCHES.txt file for drupal                                                                                                                            [ok]

BUILD FINISHED

@pvhee
Copy link
Contributor

pvhee commented Feb 18, 2016

@Saphyel great feedback, was about to run this myself on my laptop to cross check :) will merge in!

@pvhee
Copy link
Contributor

pvhee commented Feb 18, 2016

@Saphyel can you remove the original makefiles as well pls?

@pvhee
Copy link
Contributor

pvhee commented Feb 18, 2016

@Saphyel should we maybe also split up development modules from other modules (in contrib/) like agov is doing?

@Saphyel
Copy link
Contributor Author

Saphyel commented Feb 18, 2016

oks, but acquia keep them both I dunno the reason
and about split contrib... if we are going to do, the sooner the better, because if someone is working in something he will need to run registry rebuild or do a phing install with the posibility of loose his/her work

@pvhee
Copy link
Contributor

pvhee commented Feb 18, 2016

@Saphyel don't think there's a reason :)

what does agov do to split up modules?

@Saphyel
Copy link
Contributor Author

Saphyel commented Feb 18, 2016

Everything into contrib folder @pvhee

@pvhee
Copy link
Contributor

pvhee commented Feb 18, 2016

@Saphyel cool let's keep as is then, only remove .make and we're good. I think lightning must keep them to support more versions of drush, but we don't care much about that at this stage

@Saphyel
Copy link
Contributor Author

Saphyel commented Feb 18, 2016

I think Drush 7 support .yml and you can't use drush 6 with D8

pvhee added a commit that referenced this pull request Feb 18, 2016
@pvhee pvhee merged commit 86ca323 into develop Feb 18, 2016
@pvhee pvhee deleted the feature/PLAT-32_move_2_yml branch February 18, 2016 17:32
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants