Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-287 update core #300

Merged
merged 4 commits into from
Jun 7, 2016
Merged

PLAT-287 update core #300

merged 4 commits into from
Jun 7, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Jun 2, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-287

I had to delete a patch because it doesn't apply but that patch seems like is not clear what is going there

patch:
# List unmet dependencies instead of just failing
# @see https://www.drupal.org/node/2655104
- https://www.drupal.org/files/issues/missing-dependencies-2655104-8.patch
# Make inherited install profiles load base profile modules/themes in correct order
# @see https://www.drupal.org/node/1356276
- https://www.drupal.org/files/issues/make_inherited_install-1356276-133.patch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bimsonz you wrote something in that issue, how useful is that one?

@Saphyel
Copy link
Contributor Author

Saphyel commented Jun 3, 2016

I tested it on my local and nothing breaks, and all changes that they did are mainly fixes so I think it's safe update.

@bimsonz
Copy link
Contributor

bimsonz commented Jun 3, 2016

Id like to get the site fully end to end tested first before we update campaign core. This way we have some basis of regression testing, if we throw it in now and something found not working we have a starting point. If we can get the testing done and then this testing done in time im happy for it to go in

@Saphyel
Copy link
Contributor Author

Saphyel commented Jun 3, 2016

In platform works like a charm, I didn't test in RND so far

@bimsonz
Copy link
Contributor

bimsonz commented Jun 3, 2016

Im talking proper QA testing, ill make sure this is arranged

@Saphyel Saphyel added this to the RND17 June milestone Jun 6, 2016
@bimsonz
Copy link
Contributor

bimsonz commented Jun 6, 2016

Being tested here: https://github.com/comicrelief/rnd17/pull/42 if there is no regression from testing, i will merge this

@bimsonz bimsonz removed the in QA label Jun 7, 2016
@bimsonz bimsonz merged commit bd448d3 into develop Jun 7, 2016
@bimsonz bimsonz deleted the feature/PLAT-287_update_core branch June 7, 2016 10:32
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants