Adds some basic 'Rules of the Road' #33
Conversation
| ### Feature branches | ||
| All work should be done in a feature branch including the JIRA ticket number and a brief description. Ie. | ||
|
|
||
| `feature/PLAT-112_responsive_image_sizes` |
There was a problem hiding this comment.
@peter-brady by your rule we should not allow this PR to be merged in ;)
There was a problem hiding this comment.
@gusliedke What do you mean?
There was a problem hiding this comment.
@gusliedke and they're not my rules. It's just an attempt to get down some guiding ideas down for team discussion so everybody knows how the build is being approached.
There was a problem hiding this comment.
@peter-brady he means that you are not following this rules (check your description PR XD)
|
Really nice rules @peter-brady ! |
|
@pvhee & @peter-brady https://github.com/blog/2111-issue-and-pull-request-templates I think is worthy to add here this |
|
@peter-brady can you integrate some of the feedback pls, so we get this merged in asap? |
|
@peter-brady I'll take over this PR, and evolve the docs a bit more as well, then ping you and the rest of the team to review again |
peter-brady
force-pushed
the
readme_rules_of_the_road
branch
2 times, most recently
from
ce06728
to
b878282
Compare
|
@pvhee All good. Feel free to take this one. Thanks. |
|
SVG over Font Icons |
|
@pvhee shall we get this one merged in ? |
|
@bimsonz @peter-brady made some more changes, can you review again and merge if all OK? |
Adds some basic 'Rules of the Road'
No description provided.