This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
PLAT-316 Enable dev mode phing command #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -182,4 +184,8 @@ | |||
| <target name="info:code:cbf" description="Fix some quality errors of the PHP code."> | |||
| <exec logoutput="true" command="${c.home}bin/phpcbf ${cs.standard} ${app.code}" /> | |||
| </target> | |||
| <!-- Dev target to enable site in dev mode --> | |||
| <target name="enable-dev-mode" description="Enable developer mode for this site"> | |||
| <exec logoutput="true" passthru="true" command="${drush.bin} en devel -y"/> | |||
There was a problem hiding this comment.
I thought this is about stage_file_proxy also in the Dev Days I discovered webprofiler and I just love it! WE MUST HAVE IT!!!
|
Can we call it |
| @@ -9,6 +9,7 @@ | |||
| <property name="cs.standard" override="true" value="--standard=Drupal"/> | |||
| <property name="cs.ext" override="true" value="--extensions=php,module,inc,install,test,profile,theme"/> | |||
| <property name="db.querystring" override="true" value="mysql://root:@localhost/campaign"/> | |||
| <property name="app.dev_modules" value="webprofiler kint"/> | |||
There was a problem hiding this comment.
@Saphyel I think we should not enable webprofiler by default when you get a local db and enable dev mode. Could you split this up maybe, like app.dev_modules and app.dev_perf_modules, or whatever works better for you.
|
@bimsonz I've changed the name of the command as per your suggestion |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.comicrelief.com/browse/PLAT-316
Changes proposed in this pull request
dev-mode:enabletarget that is run as part ofdbtarget, does some dev workstage_file_proxy(see https://github.com/comicrelief/rnd17/pull/57)