Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-328 fix default content #343

Merged
merged 11 commits into from
Jun 29, 2016
Merged

Conversation

bimsonz
Copy link
Contributor

@bimsonz bimsonz commented Jun 28, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-328

The bhat test ive added for landing pages needs to be updated once the default content has been added for the new paragraph types.

Entity Reference Revisions was the issue, this happened last time we had this problem, we really need to be testing this work before its merged...

@bimsonz
Copy link
Contributor Author

bimsonz commented Jun 28, 2016

I re upgraded focal point and had a look into the issue, the way focal point has been implemented this time round, isnt applying itself to all the image fields within our landing page, @Saphyel can you look into, paragraphs, blocks and standard node image fields and the implimentation? during validation, some entities dont have the 'focal_point' keys, this is also causing the field should be in the form "leftoffset,topoffset" error. in campaign/profiles/cr/modules/contrib/focal_point/src/Plugin/Field/FieldWidget/FocalPointImageWidget.php

Ill revert this to 5eeab44 in the morning and we can merge it in @pvhee

@bimsonz
Copy link
Contributor Author

bimsonz commented Jun 28, 2016

In the old version, our default content does not contain focal points, on fresh install the focal_point table is empty, this would explain no focal points being migrated and probably why some of these arent working in the newer version (along with what i mentioned above). Once this is reverted to 5eeab44 and merged, ill look into exporting the focal points when i update the default content tomorrow.

@pvhee
Copy link
Contributor

pvhee commented Jun 29, 2016

@bimsonz looking good, thanks for the digging!

Morale of the story, when we tackle issues like http://jira.comicrelief.com/browse/PLAT-296 we need to be testing this more thoroughly:

  • manual test using phing build
  • upgrade path test (for RND)
  • write a series of behat tests that involve the usage of the updated modules so we safeguard this for the future

Will merge when goes green

\cc @Saphyel

@pvhee pvhee merged commit 75f8242 into develop Jun 29, 2016
@pvhee pvhee deleted the feature/PLAT-328_fix_default_content branch June 29, 2016 07:32
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants