-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
I re upgraded focal point and had a look into the issue, the way focal point has been implemented this time round, isnt applying itself to all the image fields within our landing page, @Saphyel can you look into, paragraphs, blocks and standard node image fields and the implimentation? during validation, some entities dont have the 'focal_point' keys, this is also causing the Ill revert this to 5eeab44 in the morning and we can merge it in @pvhee |
In the old version, our default content does not contain focal points, on fresh install the focal_point table is empty, this would explain no focal points being migrated and probably why some of these arent working in the newer version (along with what i mentioned above). Once this is reverted to 5eeab44 and merged, ill look into exporting the focal points when i update the default content tomorrow. |
@bimsonz looking good, thanks for the digging! Morale of the story, when we tackle issues like http://jira.comicrelief.com/browse/PLAT-296 we need to be testing this more thoroughly:
Will merge when goes green \cc @Saphyel |
Fixes https://jira.comicrelief.com/browse/PLAT-328
The bhat test ive added for landing pages needs to be updated once the default content has been added for the new paragraph types.
Entity Reference Revisions was the issue, this happened last time we had this problem, we really need to be testing this work before its merged...