-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
* @ajax : test ajax content | ||
* @frontend : related with FE | ||
* @backend : related with BE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saphyel I'm not sure how meaningful BE/FE distinction is for doing behat tests? The search tests below you tag using "back-end" but your' testing end-user behavior (thus, front-end). What is the idea behind this?
I like generally though to have the other distinctions you proposed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pvhee when I finish to update the features probably will be more clear... anyway, if we test for instance that search works, is "backend" if we test some view modes are there or later on with selenium some colors, etc.. thats frontend.
The names and description of the tags are still subject to change (and the total of them) so please be my guest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saphyel not really agreeing with this change and I don't see this reflected in the features either, so tempted to not merge this PR with incomplete instructions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also add @content
for tests that rely on content provided by cr_default_content
e5f6398
to
a2dfda2
Compare
it's failing this line:
|
b7186bb
to
be54ec2
Compare
I think this PR is ready to merge when someone fix the problems with the gems (I think webops updated a gem on Thursday and since then every build fails FYI @davidedimauro88 @roryirvine ). |
@Saphyel can you point us to the gem you think might have been updated please? The Gemfile.lock in this repo hasn't been touched for two months and our last update to craft-drush was 3-4 weeks ago, so neither of those look like likely culprits. |
@roryirvine you suppose to don't work today, check it on monday!
|
@Saphyel this is very random! I also had this problem in #351 where you see the first one working and the second one failing. I actually restarted the second one which previously was working and now is failing!
|
@roryirvine any idea to help out with the inverse PR at #356 and make bundler work again on Travis? Do we have issues on CRAFT as well? |
| Joe Bloggs | joe.bloggs@example.com | 1 | | ||
And I am logged in as a user with the "administrator" role | ||
When I visit "admin/people" | ||
Then I should see the link "Joe Bloggs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saphyel why are you removing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because is a useless test, I mean why do we need to test a core functionality? also we are going to have a limited amount of users. That test provides nothing to us.
It'll be like tests if comments or forum works...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saphyel OK
@Saphyel there's still quite some work in this PR before this is ready to go in |
@pvhee what do you think is not ready yet?? I also spoke to http://summer.drupal.cat/session/behat-drupal.html we should start to do it in different way. For instance the metatags I think could be shorten ? |
composer install | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saphyel can you link also to https://github.com/comicrelief/campaign/blob/develop/docs/testing.md
Fixes https://jira.comicrelief.com/browse/PLAT-271
Changes proposed in this pull request
behat:run