Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-271 refactor tests #346

Merged
merged 16 commits into from
Jul 13, 2016
Merged

PLAT-271 refactor tests #346

merged 16 commits into from
Jul 13, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Jun 29, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-271

Changes proposed in this pull request

  • Update documentation.
  • Update actual tests.
  • Improve behat autoloader.
  • Remove useless tests.
  • Add behat dir for the console command behat:run

@Saphyel Saphyel added this to the RND17 September milestone Jun 29, 2016
@Saphyel Saphyel self-assigned this Jun 29, 2016
* @ajax : test ajax content
* @frontend : related with FE
* @backend : related with BE
Copy link
Contributor

@pvhee pvhee Jun 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saphyel I'm not sure how meaningful BE/FE distinction is for doing behat tests? The search tests below you tag using "back-end" but your' testing end-user behavior (thus, front-end). What is the idea behind this?

I like generally though to have the other distinctions you proposed

Copy link
Contributor Author

@Saphyel Saphyel Jun 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvhee when I finish to update the features probably will be more clear... anyway, if we test for instance that search works, is "backend" if we test some view modes are there or later on with selenium some colors, etc.. thats frontend.

The names and description of the tags are still subject to change (and the total of them) so please be my guest.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saphyel not really agreeing with this change and I don't see this reflected in the features either, so tempted to not merge this PR with incomplete instructions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add @content for tests that rely on content provided by cr_default_content

@Saphyel Saphyel force-pushed the feature/PLAT-271_refactor_tests branch from e5f6398 to a2dfda2 Compare July 1, 2016 11:23
@Saphyel
Copy link
Contributor Author

Saphyel commented Jul 1, 2016

it's failing this line:

    <exec logoutput="true" passthru="true" checkreturn="true" command="bundle install --path vendor/bundle --without craft"/>

@Saphyel Saphyel force-pushed the feature/PLAT-271_refactor_tests branch from b7186bb to be54ec2 Compare July 1, 2016 15:36
@Saphyel
Copy link
Contributor Author

Saphyel commented Jul 1, 2016

I think this PR is ready to merge when someone fix the problems with the gems (I think webops updated a gem on Thursday and since then every build fails FYI @davidedimauro88 @roryirvine ).

@roryirvine
Copy link

@Saphyel can you point us to the gem you think might have been updated please? The Gemfile.lock in this repo hasn't been touched for two months and our last update to craft-drush was 3-4 weeks ago, so neither of those look like likely culprits.

@Saphyel
Copy link
Contributor Author

Saphyel commented Jul 1, 2016

@roryirvine you suppose to don't work today, check it on monday!

Fetching git@github.com:comicrelief/craft-drush.git
Fetching gem metadata from https://rubygems.org/.............
Fetching additional metadata from https://rubygems.org/..
Resolving dependencies...
Installing rake 11.2.2
Installing concurrent-ruby 1.0.2
Installing i18n 0.7.0
Installing minitest 5.9.0
Installing thread_safe 0.3.5
Installing tzinfo 1.2.2
Gem::InstallError: activesupport requires Ruby version >= 2.2.2.
An error occurred while installing activesupport (5.0.0), and Bundler cannot
continue.
Make sure that `gem install activesupport -v '5.0.0'` succeeds before bundling.

@pvhee
Copy link
Contributor

pvhee commented Jul 1, 2016

@Saphyel this is very random! I also had this problem in #351 where you see the first one working and the second one failing. I actually restarted the second one which previously was working and now is failing!

I actually think the change is coming from my PR that this this file: https://github.com/comicrelief/campaign/blob/develop/profiles/cr/tests/behat/composer.lock as part of this PR #350 but somehow that never failed... really weird! Care to look further into it and maybe revert my changes to the lock file before we find out more?
Not sure now, after I reverted that commit in #352 and I confused gemfile.lock with composer.lock! needs further research!

@pvhee
Copy link
Contributor

pvhee commented Jul 2, 2016

@Saphyel Fixed via #355

@roryirvine any idea to help out with the inverse PR at #356 and make bundler work again on Travis? Do we have issues on CRAFT as well?

| Joe Bloggs | joe.bloggs@example.com | 1 |
And I am logged in as a user with the "administrator" role
When I visit "admin/people"
Then I should see the link "Joe Bloggs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saphyel why are you removing this?

Copy link
Contributor Author

@Saphyel Saphyel Jul 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because is a useless test, I mean why do we need to test a core functionality? also we are going to have a limited amount of users. That test provides nothing to us.
It'll be like tests if comments or forum works...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvhee
Copy link
Contributor

pvhee commented Jul 2, 2016

@Saphyel there's still quite some work in this PR before this is ready to go in

@Saphyel
Copy link
Contributor Author

Saphyel commented Jul 11, 2016

@pvhee what do you think is not ready yet?? I also spoke to http://summer.drupal.cat/session/behat-drupal.html we should start to do it in different way.

For instance the metatags I think could be shorten ?

composer install
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvhee pvhee merged commit 73a057b into develop Jul 13, 2016
@pvhee pvhee deleted the feature/PLAT-271_refactor_tests branch July 13, 2016 14:53
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants