Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-330 Behat test for landing page creation #348

Merged
merged 6 commits into from
Jun 29, 2016

Conversation

pvhee
Copy link
Contributor

@pvhee pvhee commented Jun 29, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-330

Changes proposed in this pull request

  • behat test to create landing page incl. paragraph types

@bimsonz
Copy link
Contributor

bimsonz commented Jun 29, 2016

Looks good to me! runs good on travis, be cool to extend this to to add a paragraph of each type! you want this merged or we going to keep it going ? @pvhee

@pvhee
Copy link
Contributor Author

pvhee commented Jun 29, 2016

@bimsonz Let' keep it going, I'm writing a feature context to allow us to create a full landing page with different paragraphs as a test as well

@bimsonz
Copy link
Contributor

bimsonz commented Jun 29, 2016

Wicked! Look forward to seeing what can be done, want to learn more bhat

@pvhee
Copy link
Contributor Author

pvhee commented Jun 29, 2016

@bimsonz @Saphyel check my latest commits to see how we can create landing page with paragraphs, all in easy to read code, like

    And I am viewing a landing page with the following paragraphs:
    | type | title | body | variant |
    | cr_rich_text_paragraph | | Rich text paragraph | |
    | cr_single_message_row | SMR Title | SMR Body | title-above-image-right |

Works locally, let's see what Travis thinks..

….com:comicrelief/campaign into feature/PLAT-330_behat_landing_page_creation
@pvhee
Copy link
Contributor Author

pvhee commented Jun 29, 2016

@bimsonz can be merged for me! we can now extend with each new paragraph type

\cc @gusliedke @AndyEPhipps @wagg-matt

@bimsonz bimsonz merged commit 99778df into develop Jun 29, 2016
@bimsonz bimsonz deleted the feature/PLAT-330_behat_landing_page_creation branch June 29, 2016 20:36
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants