This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
Feature/plat 332 naming conv #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gusliedke did a review of this, and looks good. We need to add more docs on e.g. naming of modules, views, etc. I believe, but we can also keep extending this doc as we go along so tempted to merge this in if also @AndyEPhipps / @wagg-matt give their OK |
|
@pvhee had a good read through and am happy with the naming conventions providing @AndyEPhipps is. When we get to something a little more complex, might be worth adding one or two of those into the docs as examples. @gusliedke ^^ |
|
Gonna merge this! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.comicrelief.com/browse/PLAT-332
Changes proposed in this pull request