Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-345 Build css/js #364

Merged
merged 1 commit into from
Jul 7, 2016
Merged

PLAT-345 Build css/js #364

merged 1 commit into from
Jul 7, 2016

Conversation

bimsonz
Copy link
Contributor

@bimsonz bimsonz commented Jul 7, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-345

@pvhee Travis should now, hopefully not throw the .js file not found error

@bimsonz
Copy link
Contributor Author

bimsonz commented Jul 7, 2016

@pvhee travis is happy now, although it brings up some search issues

 [notice] No log messages available.
 [notice] No log messages available.
 ID  Date          Type      Severity  Message                                  
 67  07/Jul 12:25  access    warning   /user/logout                             
                   denied                                                       
 66  07/Jul 12:25  search_a  warning   Warning: While indexing items on search  
                   pi                  index CR Content, 1 item(s) did not have 
                                       a view mode configured for the Rendered  
                                       item processor.                          
 62  07/Jul 12:25  access    warning   /user/logout                             
                   denied                                                       
 59  07/Jul 12:24  search_a  warning   An overlong word (more than 50           
                   pi_db               characters) was encountered while        
                                       indexing:                                
                                       b49ec9fda8f521543a0ebf445736473c5d5036d7 
                                       a3d9719bb4258b06c5fcea2a.Database search 
                                       servers currently cannot index s         
 58  07/Jul 12:24  search_a  warning   An overlong word (more than 50           
                   pi_db               characters) was encountered while        
                                       indexing:                                
                                       24b0c9265257671d4f3b20bd5e319270884be1cd 
                                       7b9be20e9f74b70f9269e65a.Database search 
                                       servers currently cannot index s         
 57  07/Jul 12:24  search_a  warning   Warning: While indexing items on search  
                   pi                  index CR Content, 6 item(s) did not have 
                                       a view mode configured for the Rendered  
                                       item processor.    

Search needs some work anyway right ? this should probably just go in!

@pvhee
Copy link
Contributor

pvhee commented Jul 7, 2016

Cool, yeah, those warnings are known and we need to do a bunch of work on search anyways still (cc @Saphyel )

@bimsonz The build now takes 11 minutes though, that's superlong... I'm still in favor of not running also the compilation for campaign, but do it for RND.. what do you think?

@pvhee pvhee merged commit de6ef62 into develop Jul 7, 2016
@pvhee pvhee deleted the feature/PLAT-345_move_cache_clear branch July 7, 2016 12:40
@bimsonz
Copy link
Contributor Author

bimsonz commented Jul 7, 2016

@pvhee seems to vary, this one on develop took 12! https://travis-ci.com/comicrelief/campaign/builds/27955621 and that's before this one even went in... We do need to review this for sure, ill have a think, also when we do more ci, might speed up (also why im keep to have mvp0 as if we can build in a docker container with prebaked deps, this would speed it up alot)

@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants