This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
PLAT-353 Moving cards options to PHP and out of YML #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gusliedke we forgot to handle this as part of #360 - fixing this here and let's keep an eye out for this. |
| @@ -15,7 +15,9 @@ use Drupal\Core\Field\FieldStorageDefinitionInterface; | |||
| */ | |||
| function cr_cards_field_cr_cards_background(FieldStorageDefinitionInterface $definition, FieldableEntityInterface $entity = NULL) { | |||
| $values = [ | |||
| 'cards-black' => t('Black'), | |||
There was a problem hiding this comment.
Somehow I think we started the work but never finished @gusliedke ?
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.comicrelief.com/browse/PLAT-353
Warning: this change is critical if not deployments will fail and options won't be able to be changed once the field has field values in the database!