Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

RND-210 Partners block #381

Merged
merged 17 commits into from
Jul 22, 2016
Merged

RND-210 Partners block #381

merged 17 commits into from
Jul 22, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Jul 18, 2016

Fixes https://jira.comicrelief.com/browse/RND-210

Changes proposed in this pull request

  • Add a new Paragraph
  • Add a new view mode
  • Add template
  • Add tests

- field.field.paragraph.partner_list.field_partner_list
- field.field.node.partner.body
- field.field.node.partner.field_partner_image
- field.field.node.partner.field_partner_category
- field.field.node.partner.field_partner_website
- field.field.node.partner.field_partner_logo
- field.field.node.partner.field_partner_meta_tags
- field.storage.paragraph.field_partner_body
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saphyel The field storage needs to be at the top like all the others, can we switch these two around please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bimsonz my bad I added them in the wrong way! thanks!

@Saphyel Saphyel changed the title RND-210 Partners RND-210 Partners block Jul 19, 2016
| cr_rich_text_paragraph | | http://dummyimage.com/400x16:9 | <h2>Rich text bg title</h2> <p>Rich text paragraph body </p> | | | | |
| single_msg | Single Message 1 | http://dummyimage.com/400x16:9 | SMR 1 with cream grey background | | bg--cream-grey | 0 | 0 |
| single_msg | Single Message 2 | http://dummyimage.com/400x16:9 | SMR 2 with white background | | bg--white | 1 | 1 |
Given I am logged in as a user with the "Administrator" role
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use Editor role here rather than Admin ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bimsonz changed! good hawk eye!

@gusliedke gusliedke merged commit 1cd9c75 into develop Jul 22, 2016
@gusliedke gusliedke deleted the feature/RND-210_partners branch July 22, 2016 09:57
Saphyel added a commit that referenced this pull request Jul 25, 2016
* RND-210 Add a new view mode

* RND-210 Add a new paragraph

* RND-210 Update info file

* RND-210 Add new field & minor fixes

* RND-210 Update paragraph display

* RND-210 rename partners label

* RND-210 add twig templates

* RND-210 add style and styleguide template

* RND-210 remove add new partner

* RND-210 export view display

* RND-210 add margin paragraph

* RND-210 Add test for the partner lists

* RND-210 Update role
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants