This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
PLAT-322 video link #388
Merged
PLAT-322 video link #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/PLAT-322_video_link
…o build so it can be refactored afterwards
|
@AndyEPhipps @gusliedke ready for review. Have moved the lightcase CSS into a SASS file for us to use, removed their fonts, updated some styles for the close button and the spinner - nothing else. This is due to be refactired properly afterwards but has to go in today See how it's looking here: http://pr-388-tx3mbsqmxtu74.eu.platform.sh/fundraise, top left card |
|
@wagg-matt can you replace /components/video/_lightcase.scss for /components/lightcase/... |
|
@gusliedke that's been updated, are we good to merge it when it passes travis? |
|
yeah, passing we can merge it |
|
Assigning to QA |
Merged
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.comicrelief.com/browse/PLAT-322
Changes proposed in this pull request
Deployed at http://plat-322-tx3mbsqmxtu74.eu.platform.sh/