This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
RND-274 remove youtube #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Purge youtube | ||
| */ | ||
| function cr_update_8003() { | ||
| \Drupal::service('module_installer')->uninstall(['youtube']); |
There was a problem hiding this comment.
@Saphyel we also need to remove the field itself, CMI doesn't do that for us
|
@Saphyel I'd also like you to test this within RND repo (so following the deployment process in https://github.com/comicrelief/rnd17/blob/develop/docs/developing.md from @bimsonz) |
Saphyel
force-pushed
the
feature/RND-274_youtube
branch
from
1195720
to
e5afe10
Compare
|
So I test this on RND and it works!: |
Saphyel
force-pushed
the
feature/RND-274_youtube
branch
from
e5afe10
to
ac14fdc
Compare
| @@ -30,3 +30,13 @@ function cr_update_8001() { | |||
| function cr_update_8002() { | |||
| \Drupal::service('module_installer')->install(['cr_cards', 'cr_single_msg']); | |||
| } | |||
|
|
|||
| /** | |||
| * Purge youtube module | |||
There was a problem hiding this comment.
@Saphyel can you also add a more descriptive message here, e.g. like "Remove field_XXX and uninstall youtube module" ?
Saphyel
force-pushed
the
feature/RND-274_youtube
branch
from
ac14fdc
to
b931148
Compare
|
@Saphyel what's left to be done here? |
|
@pvhee I'm doing my latest test but should be shippable in the next sprint/release (I'm using platform.sh for test that there is no problems in RND) |
added 2 commits
August 17, 2016 11:02
…e/RND-274_youtube
…aign into feature/RND-274_youtube
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.comicrelief.com/browse/RND-274
Changes proposed in this pull request