Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-250 Attribute menu link #405

Merged
merged 3 commits into from
Aug 31, 2016
Merged

PLAT-250 Attribute menu link #405

merged 3 commits into from
Aug 31, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Aug 2, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-250

Changes proposed in this pull request

  • Add attr to [menu] links
  • Test in RND17

@Saphyel Saphyel added this to the RND17 September milestone Aug 2, 2016
@gusliedke gusliedke changed the title PLAT-250 link PLAT-250 Attribute menu link Aug 2, 2016
@Saphyel Saphyel modified the milestones: 1.7, RND17 September Aug 9, 2016
@pvhee
Copy link
Contributor

pvhee commented Aug 9, 2016

@Saphyel can we get this merged in maybe? we also would need an upgrade path to enable the module?

@pvhee
Copy link
Contributor

pvhee commented Aug 10, 2016

Will merge once we fix Travis

@pvhee
Copy link
Contributor

pvhee commented Aug 10, 2016

@Saphyel - @gusliedke told me about the functionality to add a link into a new window already via CKEditor (and using the module editor_advanced_link). can we compare these and maybe use only one module for this?

@pvhee
Copy link
Contributor

pvhee commented Aug 10, 2016

@Saphyel I tested this and somehow couldn't make this to work?

I did:

  • add _blank to the Fundraise menu link
  • the fundraise menu link doesn't open in a new window

@Saphyel
Copy link
Contributor Author

Saphyel commented Aug 10, 2016

is weird I've been debugging and for some reason is not printing anything at all (doesn't work the class, rel, target..) even with the bartik theme I don't know why stop working and I'm not sure how worthy is spend time on this when maybe is gonna be something fixing this problem

@pvhee
Copy link
Contributor

pvhee commented Aug 10, 2016

@Saphyel let's put this on hold for now - there are higher priority tasks to tackle first!

@pvhee pvhee removed this from the 1.7 milestone Aug 12, 2016
@pvhee pvhee added this to the 1.9 - Feature Freeze milestone Aug 30, 2016
@pvhee
Copy link
Contributor

pvhee commented Aug 30, 2016

@gusliedke from TravisPHP Parse error: syntax error, unexpected end of file in /home/travis/build/comicrelief/campaign/profiles/cr/cr.install on line 70

@Saphyel
Copy link
Contributor Author

Saphyel commented Aug 31, 2016

@pvhee I'm not sure why but it doesn't work this branch in platform.sh! :(

@pvhee
Copy link
Contributor

pvhee commented Aug 31, 2016

@Saphyel I had deactivated this, now activating using platform environment:activate pr-405 - wait 5-10 mins and it'll be there :)

@pvhee pvhee modified the milestones: 1.10, 1.9 - Feature Freeze Aug 31, 2016
@gusliedke
Copy link
Contributor

Tested, working!

@pvhee pvhee merged commit b3499fc into develop Aug 31, 2016
@pvhee pvhee deleted the feature/PLAT-250_link branch August 31, 2016 13:25
@pvhee pvhee mentioned this pull request Sep 2, 2016
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants