PLAT-360_theme_look_feel added new colours, some need updating, updat… #406
Conversation
…ed links and removed inline links mixin in favour of a single class, added new buttons to be reviewed by Leigh Hall
…colours, updating all colour varaiables to -red
…lief/campaign into feature/PLAT-360_theme_look_feel
|
@gusliedke @AndyEPhipps not sure if you guys fancy a look at this on the way through and if there's anything in particular you think should be removed or utilised. Have added in as much as I can from the look and feel at the mo, including:
There are a couple of bits that I may need to talk to you both about as some may or may not be needed and I don't really know......give me a nudge if there's anything to look at |
| @@ -1,15 +1,15 @@ | |||
| // Fonts | |||
|
|
|||
There was a problem hiding this comment.
@wagg-matt @AndyEPhipps Thinking to change a bit here:
$font-light-oblique: "GT-Walsheim-Light-Oblique";
$font-regular: "GT-Walsheim-Regular";
....
$font-stack: helvetica, arial, sans-serif;
$body-font: $font-regular, $font-stack;
$heading-font: $font-black, $font-stack;
Better maintainable. What do you think?
There was a problem hiding this comment.
I see what you're getting at. Since the fonts may have different weights we could do the following:
$font-light-oblique: "GT-Walsheim-Light-Oblique";
$font-regular: "GT-Walsheim-Regular";
.......
$font-stack: helvetica, arial, sans-serif;
.......
Then do:
font-family: $font-regular $font-stack;
Just because the differing weights requiring a different font will mean we can't just have one for body and one for heading.
…raphy and background colours along with updating font variables
…export and failed, updated typography and buttons after review
| n: 21px, | ||
| s: 20px, | ||
| xs: 18px, | ||
| ); |
There was a problem hiding this comment.
That's on its way up
|
|
||
| @mixin font-variation($color) { | ||
| .font--#{nth($color, 1)} { | ||
| color: nth($color, 2); |
There was a problem hiding this comment.
Glad that we're still using these mixins, good stuff
…ml and full html along with adding bg colours to single message row, and cards
…develop and updated coour and font variables
Fixes https://jira.comicrelief.com/browse/
Changes proposed in this pull request
link--inline-[colour]toinline…ed links and removed inline links mixin in favour of a single class, added new buttons to be reviewed by Leigh Hall