This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
RND-288 paragraphs #415
Merged
RND-288 paragraphs #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this PR actually makes me think we should refactor our actual code (should affect only to campaign, no harm to RND17) |
Saphyel
force-pushed
the
feature/RND-288_paragraphs
branch
2 times, most recently
from
a08e95e
to
cd0d375
Compare
Saphyel
force-pushed
the
feature/RND-288_paragraphs
branch
from
cd0d375
to
9e8bd71
Compare
|
@Saphyel conflicts! can you solve I'm also reviewing the upgrade path in RND |
|
@Saphyel happy to get this merged in after conflicts have been resolved, my tests on https://github.com/comicrelief/rnd17/pull/86 are all positive |
…e/RND-288_paragraphs
|
@pvhee up to date w/ develop! |
|
@Saphyel failing! |
added 2 commits
August 10, 2016 14:53
…ampaign into feature/RND-288_paragraphs
| And I should see "The money you raise will help change lives" | ||
| And I should see "Ready to go?" | ||
| And I should see "All that's left to do is pre-order your FREE Fundraising Pack" | ||
| And I should see the link "Pre-order" |
There was a problem hiding this comment.
@Saphyel we need to keep these tests
Merged
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.comicrelief.com/browse/RND-288
Todo
fundraiseto header linksTests in RND