Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-377 cards new look #418

Merged
merged 45 commits into from
Aug 18, 2016
Merged

Conversation

gusliedke
Copy link
Contributor

@gusliedke gusliedke commented Aug 5, 2016

https://jira.comicrelief.com/browse/PLAT-377

http://pr-418-tx3mbsqmxtu74.eu.platform.sh/fundraise

Changes proposed in this pull request

  • add cards row title
  • add cards row feature option
  • add visually hidden title
  • change label to Cards Row Background Colour
  • change label to Body background colour
  • design review

@pvhee pvhee added this to the 1.6 milestone Aug 5, 2016
@Saphyel Saphyel removed this from the 1.6 milestone Aug 9, 2016
@gusliedke
Copy link
Contributor Author

Waiting for design feedback.

@pvhee pvhee modified the milestones: 1.8, 1.7 Aug 16, 2016
@Saphyel Saphyel changed the title Feature/plat 377 cards new look PLAT-377 cards new look Aug 17, 2016
width: 178%;
margin-left: -2.5%;
height: auto;
width: 105%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not able to use grid widths here to keep it relative?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, managed to remove it all, as now it has same ratio throughout breakpoints.

@AndyEPhipps AndyEPhipps merged commit 09816b9 into develop Aug 18, 2016
@Saphyel Saphyel mentioned this pull request Aug 22, 2016
@Saphyel Saphyel deleted the feature/PLAT-377_cards_new_look branch August 22, 2016 15:56
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants