This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
Remove Ruby Version from Gemfile #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidedimauro88 working fine on Travis CI and also tested this on my mac after reinstalling all gems and didn't find any issue! So happy for this to be merged in, will leave this to @Saphyel |
|
@davidedimauro88 any luck here? |
|
@Saphyel are you happy with this to go in? If so, pls merge |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @pvhee, just removed the ruby version from the Gemfile to allow all the user (or Travis) to use any ruby version they want without breaking the build process.
Also updated Gemfile.lock after fetching all the gems on my laptop!
cc\ @Saphyel