This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
PLAT-386 promo design up #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/PLAT-386_promo_design_up
…o feature/PLAT-386_promo_design_up
…o feature/PLAT-386_promo_design_up
…o feature/PLAT-386_promo_design_up
|
@pvhee ok have pushed, watching if it will update in platsh env.. |
|
@gusliedke I've pushed this again - I think the branch naming might give problems (or the fact we have only 9 envs. on platform.sh currently paid for). Let's see what it says now. |
| &:hover { | ||
| color: $colour-white; | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we need to update the mixin values here rather than just overriding it?
There was a problem hiding this comment.
Moving it to buttons.scss but we still need it as you can't control hover colour in the mixin
Merged
| @@ -91,4 +91,8 @@ | |||
| </div> | |||
| </div> | |||
| </div> | |||
| <<<<<<< HEAD | |||
| </div> | |||
| ======= | |||
There was a problem hiding this comment.
is ok having this git things here? cc// @gusliedke @AndyEPhipps
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.comicrelief.com/browse/PLAT-386
http://pr-426-tx3mbsqmxtu74.eu.platform.sh/hidden-title
Changes proposed in this pull request
Manual deployment instructions
crprofile needs to be added in manually. E.g. 443955c