Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-400 Fix config:import #430

Merged
merged 2 commits into from
Aug 16, 2016
Merged

PLAT-400 Fix config:import #430

merged 2 commits into from
Aug 16, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Aug 11, 2016

Fixes https://jira.comicrelief.com/browse/

Changes proposed in this pull request in order to fix the config:import

Warnings:

  • Fix cr_content_wall...
  • Fix cr_cards...
  • Fix cr_landing_page...

Errors:

  • Fix cr_articles...
  • Fix cr_downloadables...

@@ -9,7 +9,6 @@ dependencies:
- field.field.node.article.field_article_publish_date
- field.field.node.article.field_article_tags
- field.field.node.article.field_youtube_url
- field.field.node.article.publishing_date
Copy link
Contributor

@pvhee pvhee Aug 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saphyel we need this field, why is it being removed? this built by @wagg-matt as part of the scheduling work AFAIK

@pvhee
Copy link
Contributor

pvhee commented Aug 11, 2016

@Saphyel not sure what is the direction of this PR? Can you please explain this?

@Saphyel
Copy link
Contributor Author

Saphyel commented Aug 11, 2016

@pvhee fix the import. I updated the description
if the field field.field.node.article.publishing_date is necessary why is commented out in cr_article.info.yml @wagg-matt (and why there is already another publish_date)? that field is causing troubles and not following the standard of "modulename_whatever" happy to resurrect it if is needed by other module

@wagg-matt
Copy link
Contributor

@Saphyel @pvhee I had to remove publish date to replace it with publishing date, first time exporting and did most of this manually so may not be 100% correct.

The original publish date field was todays date and would have just been confusing to have that and the scheduled updates publishing date.....clear as mud?

@pvhee pvhee added this to the 1.7 milestone Aug 16, 2016
@pvhee pvhee merged commit 2155e9e into develop Aug 16, 2016
@pvhee pvhee deleted the PLAT-400_refactor branch August 16, 2016 09:43
@Saphyel Saphyel mentioned this pull request Aug 16, 2016
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants