Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-399 Partners List #442

Merged
merged 13 commits into from
Aug 22, 2016
Merged

PLAT-399 Partners List #442

merged 13 commits into from
Aug 22, 2016

Conversation

wagg-matt
Copy link
Contributor

@wagg-matt wagg-matt commented Aug 16, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-399

Changes proposed in this pull request

Correctly align the partners row

  • add bg colour
  • design review

@wagg-matt
Copy link
Contributor Author

@pvhee can I get some platform.sh awesomeness for this please? Thanks

@pvhee
Copy link
Contributor

pvhee commented Aug 16, 2016

@wagg-matt yep - will prune branches as we've currently got 21 open and not enough environments on platform.sh

@gusliedke
Copy link
Contributor

gusliedke commented Aug 17, 2016

@wagg-matt .. I think we need to add a max width to partners wrapper
.partners-row-wrapper {
max-width: 1200px;
margin: auto;
}
Check with designers size of the ul in tablet.
@media (min-width: 740px)
.partners-row .partners-row__logos-list ul {
}
Check with designers max width for img logos on desktop
.partners-row__logos-list li {
max-width: 300px;
}

@gusliedke
Copy link
Contributor

A big one, add bg colour.

@wagg-matt wagg-matt added this to the 1.8 milestone Aug 18, 2016
@wagg-matt
Copy link
Contributor Author

@AndyEPhipps @gusliedke platform.sh is doing it's thing at present, do you guys mind doing a code review please?

@include breakpoint($screen-md-max) {
max-width: calc($max-width - (#{gutter()} * 1));
}
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mucky pup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndyEPhipps that's deliberate, this is to be added as a mixin (comment for that is at the start of the code) and this is the end of that section

@wagg-matt
Copy link
Contributor Author

@AndyEPhipps @gusliedke all of the above has now been addressed. Once you're happy, let me know and i'll build the content on platform.sh for QA

@gusliedke gusliedke changed the title plat-399 initial commit to share how it's shaping up on tablet PLAT 399 Partners List Aug 22, 2016
@gusliedke gusliedke merged commit 97f6780 into develop Aug 22, 2016
@gusliedke gusliedke deleted the plat-399_update_partners_list branch August 22, 2016 14:54
@Saphyel Saphyel changed the title PLAT 399 Partners List PLAT-399 Partners List Aug 22, 2016
@Saphyel Saphyel mentioned this pull request Aug 22, 2016
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants