This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
plat-431 updated colour variables, added dark purple colour variable,… #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… updated background colours: sky-blue background colour will now use dark purple as font colour, removed code for background colour styling from cards.scss
| // <div style="background-color: #fc9eb9; height: 100px; width: 100%;"></div> | ||
| // <p><br/>$colour-pink: #fc9eb9;<br/>.bg--pink</p> | ||
| // <div style="background-color: #030e1a; height: 100px; width: 100%;"></div> | ||
| // <p><br/>$colour-black: #030e1a;<br/>.bg--black</p> | ||
| // <div style="background-color: #061d38; height: 100px; width: 100%;"></div> |
There was a problem hiding this comment.
Can we not use the classes here, rather than inline styles?
gusliedke
added
Code Reviewed
Status: Reviewed
and removed
Status: Needs Review
Code Reviewed
labels
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.comicrelief.com/browse/PLAT-431
Changes proposed in this pull request