Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-375 esu head #474

Merged
merged 34 commits into from
Sep 20, 2016
Merged

PLAT-375 esu head #474

merged 34 commits into from
Sep 20, 2016

Conversation

wagg-matt
Copy link
Contributor

@wagg-matt wagg-matt commented Aug 31, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-375

Changes proposed in this pull request

  • add in ESU to the header
  • theme header version of ESU

@wagg-matt
Copy link
Contributor Author

@Saphyel Hey Carlos, could you possibly add another block for the ESU in the header please, so I can have something separate to template?

Matthew Wagg and others added 25 commits August 31, 2016 16:52
… is separate from the rest. Updated toggle to target new block and commented out lots of SASS to be refactored
…ief/campaign into feature/plat-375_ESU_head
…ief/campaign into feature/plat-375_ESU_head
…ief/campaign into feature/plat-375_ESU_head
…ief/campaign into feature/plat-375_ESU_head
… some love as the width is 100% important and overwriting that will be a challenge
…ief/campaign into feature/plat-375_ESU_head
@Saphyel Saphyel changed the title Feature/plat 375 esu head PLAT-375 esu head Sep 15, 2016
Copy link
Contributor

@gusliedke gusliedke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On error msg remove padding top, position absolute and width 47.5%.

@AndyEPhipps
Copy link
Contributor

Need to fix a tiny issue in the JS to make sure the Banner/Header hidden field is properly updated when there's multiple ESUs on the page, don't merge yetttttt

@gusliedke gusliedke added this to the 1.12.0 milestone Sep 20, 2016
@AndyEPhipps AndyEPhipps modified the milestones: 1.13.0, 1.12.0 Sep 20, 2016
@gusliedke gusliedke modified the milestones: 1.12.0, 1.13.0 Sep 20, 2016
@gusliedke gusliedke merged commit b6c3f51 into develop Sep 20, 2016
@gusliedke gusliedke deleted the feature/plat-375_ESU_head branch September 20, 2016 10:11
@Saphyel Saphyel mentioned this pull request Sep 20, 2016
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants