This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ief/campaign into feature/plat-375_ESU_head
@Saphyel Hey Carlos, could you possibly add another block for the ESU in the header please, so I can have something separate to template? |
… is separate from the rest. Updated toggle to target new block and commented out lots of SASS to be refactored
…ief/campaign into feature/plat-375_ESU_head
…ief/campaign into feature/plat-375_ESU_head
…mpaign into feature/plat-375_ESU_head
…ief/campaign into feature/plat-375_ESU_head
…ief/campaign into feature/plat-375_ESU_head
… some love as the width is 100% important and overwriting that will be a challenge
…ief/campaign into feature/plat-375_ESU_head
…m the second message onwards
…e/plat-375_ESU_head
…e/plat-375_ESU_head
gusliedke
suggested changes
Sep 16, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On error msg remove padding top, position absolute and width 47.5%.
gusliedke
approved these changes
Sep 16, 2016
…e/plat-375_ESU_head
Need to fix a tiny issue in the JS to make sure the Banner/Header hidden field is properly updated when there's multiple ESUs on the page, don't merge yetttttt |
Merged
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.comicrelief.com/browse/PLAT-375
Changes proposed in this pull request