PLAT-428 Adding lib to makefile and updating the definition in .lib file #523
Conversation
| @@ -6,7 +6,7 @@ global-css: | |||
|
|
|||
| global-js: | |||
| js: | |||
| libraries/lightcase/js/lightcase.js: {} | |||
| libraries/lightcase/src/js/lightcase.js: {} | |||
There was a problem hiding this comment.
@bimsonz if the lib location changed, shouldn't we also commit this change to git?
if @gusliedke is happy with this (and if the lib still works) let's get it merged
There was a problem hiding this comment.
@pvhee Good point, ive run phing make and committed the change
|
@gusliedke can you check this pls and make sure all is correct? |
|
@gusliedke if you could let me know if there is anything else to do before you lot go so i can get this into the next release would be great :) |
|
@gusliedke have another look pls? |
|
@bimsonz ping |
|
So are we just adding lightcase to make file and changing location path (adding /src)?! |
|
@gusliedke correct, this way we can lock down the version of the library and easily update it when the next version is released. The /src directory is just the default way it downloads so updating the definition in our theme is the more logical step to make it all tie together |
|
great! merging |
Fixes https://jira.comicrelief.com/browse/PLAT-428
Changes proposed in this pull request