RND-349 Fundraise ESU #537
Conversation
| set classes = [ | ||
| 'block-cr-email-signup', | ||
| 'block--cr-email-signup', | ||
| 'block--cr-email-signup--standard', |
There was a problem hiding this comment.
@AndyEPhipps @gusliedke I've added the standard class as im under the impression its to look like the standard one, feel free to change if you need to make any new rules or tweaks
There was a problem hiding this comment.
@bimsonz: think we'll need to add another class this to hide/show the right stuff after the single submission.
Something like 'block--cr-email-signup--fundraising' or better yet 'block--cr-email-signup--simple' so it describes the type rather than the context it's normally used in?
Holla when the BE is done and i'll scope it out
Holla when you're done with the BE and will give it a lil tweak
There was a problem hiding this comment.
The backend is done @AndyEPhipps, We went in a different direction with this, its now a separate block. Check the platform sh site, should be set up on there :)
|
@Saphyel Could you review and merge please mate? We'll chat about your changes to the classes once your back :) the ticket is RND-349 not PLAT- just to be clear! |
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| protected function esuRequiredFields() { |
There was a problem hiding this comment.
you can cast out this whole function
There was a problem hiding this comment.
care to elaborate a little please dude ?
There was a problem hiding this comment.
You are extending the class SignUp and already provides that form.. so I don't know why do you want to duplicate the form
|
it looks good if you change that |
Fixes https://jira.comicrelief.com/browse/RND-349
Changes proposed in this pull request