This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
plat-485 Fix Search Front End (theme to be updated later) #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to make the page functional again
Heleen-cr
added
Status: Needs Work
Status: Needs Review
and removed
Status: Needs Work
labels
Heleen-cr
changed the title
Saphyel
suggested changes
Oct 4, 2016
| {% elseif (field_article_image) %} | ||
| <div class="search-result__image search-result--{{ nodetype }}__image"> | ||
| {{ field_article_image }} | ||
| </div> | ||
| {% endif %} | ||
| </div> |
There was a problem hiding this comment.
@Heleen-cr could you add a new line at the end of the file? thanks!
added 2 commits
October 4, 2016 12:34
AndyEPhipps
reviewed
Oct 4, 2016
| </div> | ||
| </div> | ||
| {% elseif (field_article_image) %} | ||
| <div class="search-result__image search-result--{{ nodetype }}__image"> |
There was a problem hiding this comment.
It'd be a little nicer to construct these classes up top in a class array: https://www.drupal.org/docs/8/theming-drupal-8/using-attributes-in-templates
There was a problem hiding this comment.
Create an array for each element? search-result, title, logo and img .. problem also is to add search-result--{{ nodetype }} in the array. Can we do that?
I would change search-result--{{ nodetype }}__image to search-result__title--nodetype
There was a problem hiding this comment.
I will do those changes in another PR.. merging this one now
Saphyel
approved these changes
Oct 6, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.comicrelief.com/browse/PLAT-485
Changes proposed in this pull request