This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
PLAT-471 News articles #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
October 7, 2016 13:40
…publish date field to use as field to print the publishing date
…nged order of title and publish date
… and put styling into own component.
added 5 commits
October 12, 2016 17:06
…header region of view and added publish date to teaser view mode
…ed news articles will go in here
Heleen-cr
force-pushed
the
PLAT-471-news-articles
branch
from
a7482a4
to
aabe834
Compare
added 7 commits
October 14, 2016 11:14
…d related articles view
|
@Heleen-cr is that going in for tomorrow release? |
|
trying to. What time do you need it the latest? |
|
Ideally tomorrow before standup, but we can wait until end of the day tomorrow |
gusliedke
reviewed
Oct 17, 2016
| <div class ='cr-article__image'> | ||
| {{ field_article_image }} | ||
| </div> | ||
| <div class ='cr-article__video'> |
There was a problem hiding this comment.
@Heleen-cr I think we need to add conditions here if not it will show the markup when field is empty
| <div class="related-articles__item"> {{ row }} </div> | ||
| {% endfor %} | ||
| </div> | ||
| <div class="related-articles__footer"> |
There was a problem hiding this comment.
condition here to not show the markup now that we don't have footer
| } | ||
| } | ||
| @include breakpoint($screen-md){ | ||
| padding: $row-padding--md; |
There was a problem hiding this comment.
there is no selector for this rule
added 4 commits
October 17, 2016 16:59
…actored at some point. Added some conditions to template file news article and related articles view. Commented out social links for now
…not in the design
gusliedke
added
Status: Reviewed
Code Reviewed
and removed
Status: Needs Review
Status: Needs Work
labels
Merged
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.comicrelief.com/browse/PLAT-471
Changes proposed in this pull request