Feature/plat 528 iframe block #569
Conversation
|
@gusliedke here is the preview of the kids game -- http://dev.goodboydigital.com/client/comicrelief/adventure/ Can we use this for testing the iframe? |
|
@pvhee link game is not working |
|
Only had a brief look over this but it looks good to me |
| {{ field_cr_iframe_embedded_image }} | ||
| </div> | ||
| </a> | ||
| <iframe width="100%" height="100%" id="play-iframe" data-src="{{ field_cr_iframe_embedded_link }}" src="about:blank"> |
There was a problem hiding this comment.
Seeing as you're using a css id there, are we sure there's only even gonna be one of these on any page?
There was a problem hiding this comment.
yeah, make sense to have class in case there is more then one .. will change
| bottom: 0; | ||
| left: 0; | ||
| width: 100vw; | ||
| height: 100vh; |
There was a problem hiding this comment.
I know iOS doesn't support the VW and VH units, so we may need to change this
There was a problem hiding this comment.
ok, I will use % or add it as fallback
|
@AndyEPhipps @Heleen-cr done changes and a bit more .. check it out please |
…o feature/PLAT-528_iframe_block
gusliedke
added
Status: Reviewed
Code Reviewed
and removed
Status: Needs Work
Status: Needs Review
labels
|
@gusliedke happy for me to merge this yeah ? |
|
@bimsonz yes |
https://jira.comicrelief.com/browse/PLAT-528
TO DO