This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
RND-465 kids nav #579
Merged
RND-465 kids nav #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weirdly article tests are broken for this PR - did you touch anything related to that @gusliedke ? Other than that, http://pr-579-v7mya5y-tx3mbsqmxtu74.eu.platform.sh/kids looks really cool :) |
|
@Saphyel can you review and help out here to fix the tests? maybe related to the issue you had yesterday |
|
@AndyEPhipps can you review it please .. I am adding kids nav to look and behave like main nav |
|
Code all looks good @gusliedke, would just be nice to get in some 2x images for retina devices? |
|
@gusliedke travis is happy! ✅ |
…o feature/RND-465_kids_nav
…lief/campaign into feature/RND-465_kids_nav
gusliedke
force-pushed
the
feature/RND-465_kids_nav
branch
from
8632cc9
to
f9ca72f
Compare
…o feature/RND-465_kids_nav
gusliedke
added
Status: Reviewed
Code Reviewed
and removed
Status: Needs Work
Status: Needs Review
labels
…o feature/RND-465_kids_nav
|
@gusliedke could you list the manual config please dude? |
|
Chatted with Gus, the code will sit on the site but the menu needs building out by the content team! |
Merged
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.comicrelief.com/browse/RND-465
Manual deployment steps
See build instructions in JIRA
Todo