Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-502 Add body field to downloadables #582

Merged
merged 4 commits into from
Nov 1, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Oct 26, 2016

@pvhee
Copy link
Contributor

pvhee commented Oct 26, 2016

@Saphyel I'd like you to include a behat test on this as well or adapt the current tests on downloadables we have to include that.

@pvhee
Copy link
Contributor

pvhee commented Oct 26, 2016

This probably needs to include also the search api config to make sure that field is indexed, if not yet the case? or adapt the search index view mode for downloadables.

Can we include that to the search tests as well?

@Saphyel
Copy link
Contributor Author

Saphyel commented Oct 26, 2016

@pvhee what do you wanna test exactly?
So at the moment is only searching for "Display title" but if we want to be able to search the body too we must update the default view (and use a different one where we don't want to show the body)

@Saphyel
Copy link
Contributor Author

Saphyel commented Oct 27, 2016

PhantomJS has crashed :)

@bimsonz
Copy link
Contributor

bimsonz commented Oct 27, 2016

@Saphyel is this the PR where travis is failing? its related to the test that is failing... that makes me think you must have changed something...?

@Saphyel
Copy link
Contributor Author

Saphyel commented Oct 27, 2016

@bimsonz I added new view modes (for solr) and a new field (optional) but all of this is out of tests...

@Saphyel Saphyel force-pushed the feature/PLAT-502_downloadables_body branch from 8273787 to 5e57caf Compare October 27, 2016 14:49
@Saphyel Saphyel force-pushed the feature/PLAT-502_downloadables_body branch from 5e57caf to fba1d80 Compare October 27, 2016 15:09
@bimsonz bimsonz merged commit f649ed4 into develop Nov 1, 2016
@bimsonz bimsonz deleted the feature/PLAT-502_downloadables_body branch November 1, 2016 09:53
@bimsonz bimsonz mentioned this pull request Nov 1, 2016
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants