This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
PLAT-543 News landing page #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
October 27, 2016 16:30
…age and updated behat test
|
The design asks for a filter that auto-submits without a submit button. We used to have the better exposed filters plugin on sportrelief. Do we want to use this again or should we do it ourselves without the plugin? |
added 2 commits
October 31, 2016 13:58
Heleen-cr
force-pushed
the
PLAT-543-news-landing-page
branch
from
135c420
to
8c576e3
Compare
|
As discuss with @Heleen-cr seems like that D8 port has issues with ajax: https://www.drupal.org/node/2776615 |
Saphyel
force-pushed
the
PLAT-543-news-landing-page
branch
from
8c576e3
to
c1dd8bf
Compare
…ampaign into PLAT-543-news-landing-page
This reverts commit 7f641fdcf45a64926265637be53f47385b5b8c58.
This reverts commit 327a4b90eb451ca917e31789150e490ea69cbfc3.
…43-news-landing-page
AndyEPhipps
reviewed
Nov 1, 2016
| } | ||
| } | ||
| @include breakpoint($screen-md) { | ||
| .article-teaser__image, .article-teaser__video { |
There was a problem hiding this comment.
Leave it for now, but best to stick each new selector onto a new line
| .button { | ||
| width: 100%; | ||
| padding: 0.4em 1em 0.4em 1em; | ||
| border: 1px solid #cccccc; |
| @@ -75,7 +75,7 @@ | |||
| margin: -50px auto 0; | |||
| padding: 1px 0; | |||
| background: $colour-white; | |||
| @include breakpoint-gutters; | |||
| max-width: calc(#{$max-width} - (2 * #{gutter()})); | |||
There was a problem hiding this comment.
Are we happy to be changing this, seeing as it's global for all promo pages?
added 7 commits
November 1, 2016 10:51
…43-news-landing-page
…43-news-landing-page
Merged
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.comicrelief.com/browse/PLAT-543
Changes proposed in this pull request
Manual deployment instructions
(don't show titles as the title of the page will be added in the body field of the landing page)