Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-536 upgrade 8.2.1 #589

Merged
merged 3 commits into from
Oct 28, 2016
Merged

PLAT-536 upgrade 8.2.1 #589

merged 3 commits into from
Oct 28, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Oct 28, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-536 See changelog for 8.2.x

Manual deployment steps

  • Make sure to run update-core in RND17

"wikimedia/composer-merge-plugin": "~1.3"
"wikimedia/composer-merge-plugin": "~1.3",
"php-amqplib/php-amqplib": "^2.6",
"solarium/solarium": "^3.7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saphyel is this being added as a patch as well? hard to find this since so many files changed :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvhee for avoid that crappiness, I split this into 3 commits, check the last one in order to see that patch! :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, had missed this!

@pvhee
Copy link
Contributor

pvhee commented Oct 28, 2016

@gusliedke @AndyEPhipps @Heleen-cr this core update also updates the followign JS libs :

- Updated vendor libraries:
    * Updated to jQuery 2.2.3.
    * Updated to Twig 1.24.
    * Updated to CKEditor 4.5.11.
    * Updated to Symfony Routing 1.4.0.
    * Updated to Stack/Builder 1.0.4.
    * Updated to Guzzle 6.2.1.

Can you verify that our JS code will work correctly with these updated libs? Not worried about CKEditor but we should definitely verify jQuery and Twig

@AndyEPhipps
Copy link
Contributor

@pvhee will check this out locally, I can't see the jQuery update borking anything really

@pvhee
Copy link
Contributor

pvhee commented Oct 28, 2016

@AndyEPhipps you can also use the platform.sh url to just review functionality that relies on jquery

@AndyEPhipps
Copy link
Contributor

@pvhee : tested on plat.sh env, all seems well; custom ESU and nav JS all fine, Panelizer stuff fine, Twig seems to be fine (no broken styles, so all functions/logic working as before). Have done the same on the RND17 test env will the same outcome

@pvhee pvhee merged commit 25bdf34 into develop Oct 28, 2016
@pvhee pvhee deleted the feature/PLAT-536_upgrade_8.2.1 branch October 28, 2016 15:27
@bimsonz bimsonz mentioned this pull request Nov 1, 2016
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants