PLAT-47 improv

[Saphyel]

Fixes https://jira.comicrelief.com/browse/PLAT-47

Changes proposed in this pull request

• Fix make.yml
• Fix filter....yml
• Fix phing: build.xml

Deployment instructions

• No manual actions required for deployment

[pvhee]

@Saphyel do you think it would make sense as well to make phing config:export run on travis as well, and if the output is dirty (e.g. there are new file changes in the git repo), then let it fail?

[Saphyel]

@pvhee to be honest make no sense, the filter.format.yml is because the cr.install overwrite it (the code is execute after the config/install finish)... and what we develop in the future I hope should not be overwritten 😨 (if not what is the point of the yml files?)

So if the question is could be useful? Yes
if the question is should happen? No

[pvhee]

@Saphyel can we maybe then remove that line from our .info.yml so it won't be re-exported using config:export?

[Saphyel]

if we change them in the future we'll have to add them back, agov have them: https://github.com/previousnext/agov/tree/8.x-1.x/agov/config/install
Maybe we should remove the code that changes the filter.format

[pvhee]

@Saphyel could you research what is best to do here? And with agov, if you run config:export, do you also have it overwritten after install?

[Saphyel]

@pvhee could we merge this and choose later how to deal with the filter formats? I don't think they gonna be a problem in short term, and the other stuff is important to merge before someone run phing make

[pvhee]

@Saphyel definitely - merged in