PLAT-561 update ds

[Saphyel]

Fixes https://jira.comicrelief.com/browse/PLAT-561

Requires

• PLAT-558 Update layout plugin #594

Release log

• https://www.drupal.org/project/ds/releases/8.x-2.6
• https://www.drupal.org/project/ds/releases/8.x-2.5

[Saphyel]

@pvhee @gusliedke just to make sure everyone is aware of the changes in this module.. DS is trying to move away from use view modes in favour of using render entities (They will be deprecated so after merge we'll be able to still using them but maybe in next DS release will be gone the view modes in DS)

[gusliedke]

kill view modes? "move away from use view modes in favour of using render entities"

[Saphyel]

@gusliedke is not killin' them.. this module seems like they are moving from use them in the render option... we still are gonna be able to use them in other parts of Drupal and in this module for a bit longer.

You can checkout this branch and see it

[pvhee]

@Saphyel if you render entities, you render them in a given view mode; what is DS trying to change here? do you have any doc. to back up your claim?

[Saphyel]

@pvhee we can merge this because on RND17 doesn't break anything and people will start to be aware of the deprecated things (The sooner the better!)

[pvhee]

@gusliedke can you have a quick look over the new features / fixes by DS as listed above and approve as well?

UPDATE: changelog of the modules looks OK for me, nothing major really

[pvhee]

@Saphyel if this requires #594 you need to make sure that PR builds fine, currently failing on travis?

[Saphyel]

layout plugin update fails because DS is outdated so is mandatory update both (and that's why I wrote requires the other PR)

[bimsonz]

Maybe best to update both in one of the PR's so we can see travis passing...? Can always revert and still merge them separately if required.

[Saphyel]

The main reason I did 2 PR is because they are different modules, but #597 requires a higher version of #594 so one blocks the other, so travis will fail unless we update both in one go (?)

[bimsonz]

thats why im suggesting we bring one into the other.. so we avoid that situation...?

[Saphyel]

well @pvhee feel free in that case to squash this PR and close the other PR :)

[pvhee]

@Saphyel now you can fix up #594 !