RND-494 news in content wall #604

bimsonz · 2016-11-02T11:14:58Z

Fixes https://jira.comicrelief.com/browse/RND-494

Changes proposed in this pull request

Content reference block
Content reference block view modes for each size on the content wall
Update content wall row block to accept new content reference block
News article view mode(s) depending on image styles
Behat -- this is now asserted through the landing page test
@pvhee Default content, see http://pr-604-2b3tzda-tx3mbsqmxtu74.eu.platform.sh/
update styleguide

…e/RND-494_news_in_content_wall

…ll/ content reference block

…e/RND-494_news_in_content_wall

bimsonz · 2016-11-04T13:30:49Z

@gusliedke I've added an example here! http://pr-604-2b3tzda-tx3mbsqmxtu74.eu.platform.sh/fundraise //cc @pvhee

Assigning to you Gus for FE work.. please dont hesitate to shout if you need some changes made in the BE.

Its currently set up to display the news article in one content type (hoping this is flexible enough for you to do what you gotta do) but it would be easy to add a new view mode/ image style for each reference block image style (content wall styles L, M, S)

bimsonz · 2016-11-04T14:24:26Z

@pvhee Its deployed to platform and ive added a manual bit of content into the content wall!

…e/RND-494_news_in_content_wall

…omicrelief/campaign into feature/RND-494_news_in_content_wall

bimsonz · 2016-11-04T14:46:01Z

Done of the theming has been done yet anyway, will take a look once ive done this Quote block

…e/RND-494_news_in_content_wall

pvhee · 2016-11-04T16:12:52Z

@bimsonz default content + test is done - will put in the link in the PR above when it's finished.

@Heleen-cr / @gusliedke whoever picks this up: the /fundraise page has a reference to the news article on Greg James, just make it look pretty ;)

gusliedke · 2016-11-06T13:20:27Z

I'm adding contextual links via template

pvhee · 2016-11-07T10:28:52Z

@gusliedke should we do a QA pass on this as well before it's merged in?

AndyEPhipps · 2016-11-07T11:16:15Z

profiles/cr/themes/custom/campaign_base/sass/components/content-block/_content-block.scss

+    display: block;
+    width: 100%;
+    height: 100%;
+    @include transition(0.2s);


Best to target the specific transition here

AndyEPhipps · 2016-11-07T11:17:26Z

profiles/cr/themes/custom/campaign_base/sass/layout/_views.scss

 //       }
 //       @include breakpoint($screen-lg) {
-//       	@include span(4);
+//        @include span(4);
 //         &:first-child {
 //           // @include span(8);
 //         }


Can we remove this?

gusliedke · 2016-11-08T10:20:34Z

Passed QA done code changes

gusliedke · 2016-11-08T10:21:08Z

@pvhee ready to merge

bimsonz added 5 commits November 1, 2016 12:00

RND-494 Bare bones for content reference module

69471a6

RND-494 Add module to CR info file and common.xml

fdb498d

Merge branch 'develop' of github.com:comicrelief/campaign into featur…

ef3a38b

…e/RND-494_news_in_content_wall

RND-494 Update content reference block config list

7a0e172

RND-494 Add content reference block config

fd1c3c7

bimsonz added Status: Needs Work Status: Needs Review labels Nov 2, 2016

bimsonz added this to the 1.17.0 milestone Nov 2, 2016

bimsonz self-assigned this Nov 2, 2016

bimsonz added 3 commits November 2, 2016 17:34

RND-494 Reorder to make article content types available to content wa…

a8dd3a9

…ll/ content reference block

RND-494 Add viewmodes to info file

f5fc246

RNd-494 View mode config

09384b6

bimsonz force-pushed the feature/RND-494_news_in_content_wall branch from ffb5657 to 09384b6 Compare November 3, 2016 11:39

bimsonz added 11 commits November 3, 2016 14:24

Merge branch 'develop' of github.com:comicrelief/campaign into featur…

9600540

…e/RND-494_news_in_content_wall

RND-494 Fix missing conflicts

feec913

RND-494 Article updates

5bb4be2

RND-494 Content wall config updates

19618c4

RND-494 Revert News block theme dep

d47ec87

RND-494 Restore block ref

8027a62

RND-494 Restore develop

1928989

RND-494 Restore develop

dc0519a

RND-494 Remove whats going on block theme dep

bd29b11

RND-494 Config

d48a952

RND-494 News viewmodes, content block view modes

0298b28

bimsonz assigned gusliedke and unassigned bimsonz Nov 4, 2016

pvhee added 2 commits November 4, 2016 14:35

Merge branch 'develop' of github.com:comicrelief/campaign into featur…

ea7f346

…e/RND-494_news_in_content_wall

Merge branch 'feature/PLAT-588_contentwallv2_content' of github.com:c…

635ece6

…omicrelief/campaign into feature/RND-494_news_in_content_wall

pvhee closed this Nov 4, 2016

pvhee reopened this Nov 4, 2016

pvhee added 3 commits November 4, 2016 14:47

Merge branch 'develop' of github.com:comicrelief/campaign into featur…

138764a

…e/RND-494_news_in_content_wall

RND-494 Add in default content wall on the homepage

b8ae4cf

RND-494 Fix default content + add into our landing page behat test

274f572

gusliedke added 7 commits November 6, 2016 17:20

RND-494 add content block component

6696801

RND-494 add content block templates

c8dc609

RND-494 update views layout

7ac8bfa

RND-494 update article cw display mode

077e591

RND-494 update view display cw content ref l m mp s

37c32af

RND-494 update views layout style

6d4c18d

RND-494 update styleguide

b1e27d8

gusliedke added Status: Reviewed and removed Status: Needs Work labels Nov 6, 2016

AndyEPhipps reviewed Nov 7, 2016

View reviewed changes

gusliedke added 3 commits November 7, 2016 12:37

RND-494 update style review add gutters mobile

27c89ae

RND-494 remove comments

9383480

RND-494 tweak mobile gutters

9d3e434

gusliedke added Code Reviewed and removed Status: Needs Review labels Nov 8, 2016

pvhee merged commit 0f4f53d into develop Nov 8, 2016

pvhee deleted the feature/RND-494_news_in_content_wall branch November 8, 2016 10:29

bimsonz mentioned this pull request Nov 9, 2016

Release/1.17.0 #622

Merged

pvhee mentioned this pull request Jan 5, 2017

CHANGELOG.md #735

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RND-494 news in content wall #604

RND-494 news in content wall #604

bimsonz commented Nov 2, 2016 •

edited by gusliedke

bimsonz commented Nov 4, 2016

bimsonz commented Nov 4, 2016

bimsonz commented Nov 4, 2016

pvhee commented Nov 4, 2016

gusliedke commented Nov 6, 2016

pvhee commented Nov 7, 2016

AndyEPhipps Nov 7, 2016

gusliedke Nov 7, 2016

AndyEPhipps Nov 7, 2016

gusliedke Nov 7, 2016

gusliedke commented Nov 8, 2016

gusliedke commented Nov 8, 2016

RND-494 news in content wall #604

RND-494 news in content wall #604

Conversation

bimsonz commented Nov 2, 2016 • edited by gusliedke

Changes proposed in this pull request

bimsonz commented Nov 4, 2016

bimsonz commented Nov 4, 2016

bimsonz commented Nov 4, 2016

pvhee commented Nov 4, 2016

gusliedke commented Nov 6, 2016

pvhee commented Nov 7, 2016

AndyEPhipps Nov 7, 2016

Choose a reason for hiding this comment

gusliedke Nov 7, 2016

Choose a reason for hiding this comment

AndyEPhipps Nov 7, 2016

Choose a reason for hiding this comment

gusliedke Nov 7, 2016

Choose a reason for hiding this comment

gusliedke commented Nov 8, 2016

gusliedke commented Nov 8, 2016

bimsonz commented Nov 2, 2016 •

edited by gusliedke