Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

Issues on News landing page #605

Merged
merged 3 commits into from
Nov 3, 2016
Merged

Conversation

Heleen-cr
Copy link
Contributor

@Heleen-cr Heleen-cr commented Nov 2, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-585

Changes proposed in this pull request

  • change width to include breakpoint gutters again
  • override min height of 600 for the feature layout promo header

@pvhee
Copy link
Contributor

pvhee commented Nov 3, 2016

@Heleen-cr can you make sure you add in the JIRA id to every commit message pls if there is an ID?

@Heleen-cr
Copy link
Contributor Author

@pvhee yes I normally do, just when i do things too hastily I forget stuff.

@bimsonz
Copy link
Contributor

bimsonz commented Nov 3, 2016

@Heleen-cr also, this branch should have been cut from the release branch not develop, in this instance ive not got a huge issue with it as its only documentation changes that are coming in, but if more had gone into develop since the start of the release you'd have to redo this branch :)

@bimsonz bimsonz merged commit af4aa7e into 1.16.0 Nov 3, 2016
@Saphyel Saphyel deleted the PLAT-585-issues-news-landing-page branch November 3, 2016 10:59
@Heleen-cr
Copy link
Contributor Author

@bimsonz oh ok didn't know. Will do that next time!

@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants