Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-550 sitemap #613

Merged
merged 3 commits into from
Nov 8, 2016
Merged

PLAT-550 sitemap #613

merged 3 commits into from
Nov 8, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Nov 4, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-550

Manual steps

Enable the module, If /sitemap.xml is not properly generated we need to run cron.

@pvhee
Copy link
Contributor

pvhee commented Nov 4, 2016

@Saphyel exception 'Drupal\Core\Config\UnmetDependenciesException' with [error] message 'Configuration objects provided by cr_user have unmet dependencies: ' in ....

@Saphyel
Copy link
Contributor Author

Saphyel commented Nov 4, 2016

I wanted to avoid the profile but drupal loves so much stack the config in one place...

I guess this leaves more fun to the release manager.

Copy link
Contributor

@pvhee pvhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ok here - @bimsonz over to you for merging this in

@api
Scenario: Check sitemap.xml url addresses
Given I go to "/sitemap.xml"
Then I run cron
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saphyel although it doesnt make a difference, you shoukd have
Given
And
And
Then

As the and parts are part of the given clause

@bimsonz bimsonz merged commit 4e07ea4 into develop Nov 8, 2016
@bimsonz bimsonz deleted the feature/PLAT-550_sitemap branch November 8, 2016 11:01
@bimsonz bimsonz mentioned this pull request Nov 9, 2016
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants